fix issue introduced with 3.14.4 where binary data is not read

Kong · Jul 7, 2023 · 7bcb8e0 · 7bcb8e0
1 parent b8ab11e
commit 7bcb8e0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/unirest-bdd-tests/src/test/java/BehaviorTests/AsBytesTest.java b/unirest-bdd-tests/src/test/java/BehaviorTests/AsBytesTest.java
@@ -44,6 +44,15 @@ void getGetResultAsBytes() {
         cap.assertStatus(200);
     }
 
+    @Test
+    void getGetBinaryResultAsBytes() {
+        byte[] content = Unirest.get(MockServer.BINARYFILE)
+                .asBytes()
+                .getBody();
+
+        assertEquals(46246, content.length);
+    }
+
     @Test
     void getGetResultAsBytesAsync() throws Exception {
         byte[] content = Unirest.get(MockServer.GET)

diff --git a/unirest/src/main/java/kong/unirest/apache/ApacheResponse.java b/unirest/src/main/java/kong/unirest/apache/ApacheResponse.java
@@ -76,7 +76,7 @@ public InputStream getContent() {
 
     @Override
     public byte[] getContentAsBytes() {
-        if (!hasContent() || ContentType.isBinary(getContentType())) {
+        if (!hasContent()) {
             return new byte[0];
         }
         try {