issue #461 return HttpResponse<Empty> for asEmpty()

Kong · Nov 26, 2022 · aa479ff · aa479ff
1 parent e2ddec7
commit aa479ff
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 3.14.0
+* issue #461 return HttpResponse<Empty> for asEmpty()
+
 ## 3.13.13
 * Cookie dates always follow US Locale to avoid invalid unicode in headers
 

diff --git a/unirest-bdd-tests/src/test/java/BehaviorTests/AsEmptyTest.java b/unirest-bdd-tests/src/test/java/BehaviorTests/AsEmptyTest.java
@@ -25,6 +25,7 @@
 
 package BehaviorTests;
 
+import kong.unirest.Empty;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 import kong.unirest.HttpResponse;
@@ -33,13 +34,23 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNull;
 
-@SuppressWarnings("rawtypes")
+
 class AsEmptyTest extends BddTest {
 
+    @Test
+    void asEmptyParams() {
+        Unirest.get(MockServer.ERROR_RESPONSE)
+                .asEmpty()
+                .ifFailure(response -> {
+                    assertEquals("Bad Request", response.getStatusText());
+                })
+                .ifSuccess(s -> {throw new RuntimeException("fail");});
+    }
+
     @Test
     void canDoAEmptyRequestThatDoesNotParseBodyAtAll() {
         MockServer.addResponseHeader("Content-Type", "json");
-        HttpResponse res = Unirest.get(MockServer.GET).asEmpty();
+        HttpResponse<Empty> res = Unirest.get(MockServer.GET).asEmpty();
 
         assertNull(res.getBody());
         Assertions.assertEquals(200, res.getStatus());
@@ -49,7 +60,7 @@ void canDoAEmptyRequestThatDoesNotParseBodyAtAll() {
     @Test
     void canDoEmptyAsync() throws Exception {
         MockServer.addResponseHeader("Content-Type", "json");
-        HttpResponse res = Unirest.get(MockServer.GET).asEmptyAsync().get();
+        HttpResponse<Empty> res = Unirest.get(MockServer.GET).asEmptyAsync().get();
 
         assertNull(res.getBody());
         Assertions.assertEquals(200, res.getStatus());

diff --git a/unirest/src/main/java/kong/unirest/BaseRequest.java b/unirest/src/main/java/kong/unirest/BaseRequest.java
@@ -191,7 +191,7 @@ public R downloadMonitor(ProgressMonitor monitor) {
     }
 
     @Override
-    public HttpResponse asEmpty() {
+    public HttpResponse<Empty> asEmpty() {
         return request(BasicResponse::new, Empty.class);
     }
 

diff --git a/unirest/src/main/java/kong/unirest/HttpRequest.java b/unirest/src/main/java/kong/unirest/HttpRequest.java
@@ -369,7 +369,7 @@ <T> PagedList<T> asPaged(Function<HttpRequest, HttpResponse> mappingFunction,
      * Executes the request and returns the response without parsing the body
      * @return the basic HttpResponse
      */
-    HttpResponse asEmpty();
+    HttpResponse<Empty> asEmpty();
 
     /**
      * Executes the request asynchronously and returns the response without parsing the body