Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update transferable balance calculation formula #2118

Closed
Sokol142196 opened this issue Nov 1, 2023 · 7 comments · Fixed by #3042
Closed

Update transferable balance calculation formula #2118

Sokol142196 opened this issue Nov 1, 2023 · 7 comments · Fixed by #3042
Assignees
@nampc1
Labels
critical-error Critical error need to be fixed ASAP
Milestone
Milestone 7

Comments

@Sokol142196
Copy link

Describe the task
Update transferable balance calculation formula

Expect: transferable = free - max(frozen - reserved, ED)

Image
@Sokol142196 Sokol142196 added this to the Milestone 8 milestone Nov 1, 2023
@S2kael S2kael assigned S2kael and unassigned nampc1 Nov 18, 2023
@nampc1 nampc1 self-assigned this Nov 18, 2023
@nampc1
Copy link

nampc1 commented Nov 18, 2023

paritytech/substrate#12951
https://github.com/paritytech/polkadot-sdk/blob/3069b0af398e5a0374802c31201637e97f4a530a/substrate/frame/balances/src/impl_fungible.rs#L44

@nampc1
Copy link

nampc1 commented Nov 18, 2023

image

@nampc1 nampc1 removed their assignment Nov 20, 2023
@nampc1 nampc1 added the important Import task need to be focused label Nov 20, 2023
@S2kael
Copy link

S2kael commented Nov 24, 2023

paritytech/polkadot-sdk#1833

@nampc1 nampc1 added critical-error Critical error need to be fixed ASAP and removed important Import task need to be focused labels Nov 24, 2023
@nampc1 nampc1 assigned bluezdot and unassigned S2kael Nov 28, 2023
@bluezdot bluezdot mentioned this issue Dec 5, 2023
Closed
@bluezdot bluezdot linked a pull request Dec 5, 2023 that will close this issue
[Issue-2118] Update transferable balance #2303
Closed
@hieudd hieudd modified the milestones: Milestone 8, Milestone 9 Dec 13, 2023
@nampc1
Copy link

nampc1 commented Dec 15, 2023

paritytech/polkadot-sdk#1833 (comment)

@Juanma0x Juanma0x mentioned this issue Apr 2, 2024
Closed
@nampc1 nampc1 assigned S2kael and unassigned bluezdot Apr 17, 2024
@nampc1 nampc1 assigned nampc1 and unassigned S2kael May 6, 2024
@nampc1
Copy link

nampc1 commented May 7, 2024 •
edited by Sokol142196
Loading

  • Update formula calculating transferable balance
  • Update parsing system pallet
  • Update transfer max formula
  • Update validation logic when transfer token
  • Review available balance formula for other features (staking, xcm,...)

@nampc1 nampc1 mentioned this issue May 10, 2024
Merged
@nampc1 nampc1 linked a pull request May 10, 2024 that will close this issue
[Issue 2118] Update transferable balance calculation #3042
Merged
@nampc1 nampc1 removed a link to a pull request May 17, 2024
[Issue-2118] Update transferable balance #2303
Closed
@Sokol142196
Copy link
Author

Sokol142196 commented May 29, 2024 •
edited
Loading

Version test: http://14.224.129.242:8900/s/k2JG8ArrHFW443f

Please check issues:

  • Re-check swap with HydraDX provider
  • Update message in case not enough balance to stake with XCM
  • Update some other message

@Sokol142196
Copy link
Author

Version test: http://14.224.129.242:8900/s/PXR2eSmPW8JAKGb

@Sokol142196 Sokol142196 mentioned this issue Jun 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nampc1 nampc1

Labels
critical-error Critical error need to be fixed ASAP
Projects
None yet
Milestone
Milestone 7
Development

Successfully merging a pull request may close this issue.

[Issue 2118] Update transferable balance calculation Koniverse/SubWallet-Extension
5 participants
@hieudd @S2kael @nampc1 @bluezdot @Sokol142196