Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension - Update some message related to earning feature #3150

Closed
2 tasks done
Sokol142196 opened this issue May 31, 2024 · 2 comments · Fixed by #3153
Closed
2 tasks done

Extension - Update some message related to earning feature #3150

Sokol142196 opened this issue May 31, 2024 · 2 comments · Fixed by #3153
Assignees
Milestone

Comments

@Sokol142196
Copy link

Sokol142196 commented May 31, 2024

Describe the task
Update some message related to earning feature

  • Message in case Insufficient balance when withdraw, claim reward and unstake

    • Actual: Show message "Your available balance is [Available balance], you need to leave [ED] as minimal balance (existential deposit) and pay network fees. Make sure you have at least [x tokens] in your transferable balance to proceed."
    • Expect: Change to message "You don't have enough [token] (network name) to pay gas fee. Top up your transferable balance and try again"
  • Message in case Insufficient balance when stake with Liquid staking (re-check lending staking)

    • Example: stake DOT (Acala) and account have xx ACA (xx > ED) and yy (DOT) then input stake amount: DOT > Total DOT on Acala and Polkadot
    • Actual: Show message "You don't have enough ACA (Acala) to pay gas fee. Lower your amount and try again"
      • Incorrect token
    • Expect: Show message "You can only enter a maximum of xx DOT, which is xx1 DOT (Acala) and xx2 DOT (Polkadot). Lower your amount and try again."
@Sokol142196
Copy link
Author

Sokol142196 commented Jun 6, 2024

  • Update Max amount in the message in case Insufficient balance when swap
    • Actual: Shows Maximum Amount to enter but then user enters Amount = Maximum Amount then shows Insufficient Balance error message
      image

    • Expect: Shows the exact maximum amount the user can enter

@ThaoNguyen998
Copy link

Version test: http://14.224.129.242:8900/s/w9crn8y3SLXSmyn
Validation passed in case

  • Message in case Insufficient balance when withdraw, claim reward and unstake

    image

    image

image

  • Message in case Insufficient balance when stake with Liquid staking (re-check lending staking)

    image

  • Update Max amount in the message in case Insufficient balance when swap

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants