HexFormat proposal #361
HexFormat proposal #361
Conversation
|
|
||
| ## Motivation | ||
|
|
||
| Our research has shown that hexadecimal representation is more widely used than other numeric bases, |
There was a problem hiding this comment.
We don't have any public document with the results. But search in grep.app finds much more usages of toString(16) than any other base.
There was a problem hiding this comment.
Probably .toString( /* 10 */ ) is more common, should we also consider introducing DecFormat?
I'm not against this proposal; it seems strange to tackle hexadecimal number formatting before decimal ones.
There was a problem hiding this comment.
The decimal representation of numeric values is indeed more common, and this document explicitly agrees with the proposition. However, this proposal is about introducing an API to facilitate formatting (and parsing) the hex representation of binary data. It provides use cases and proposes an API to make it easy to handle those use cases.
Of course, there are other potentially more impactful features. They deserve separate proposals.
While HexFormat is not the most important or useful feature out there, it does address the pain points outlined in this document.
There was a problem hiding this comment.
Hi,
Discussion of the proposal has been moved here: #362
Please don't hesitate to express your concerns there.
| macAddress.toHexString(threeGroupFormat) // "001B.6384.45E6" | ||
| ``` | ||
|
|
||
| ## Alternatives |
There was a problem hiding this comment.
Another option is a third-party implementation. Logging, for example, is only available this way.
There was a problem hiding this comment.
Could you also please provide a link to the library you are referring to?
There was a problem hiding this comment.
proposals/stdlib/hex-format.md
Outdated
| ``` | ||
|
|
||
| `BytesHexFormat` and `NumberHexFormat` classes hold format options for `ByteArray` and numeric values, correspondingly. | ||
| `uppercase` option, which common to both `ByteArray` and numeric values, is stored in `HexFormat`. |
There was a problem hiding this comment.
Hi,
I think the uppercase option is vague.
Does uppercase = false means force all letters to lowercase or does it mean keep the letters as is (not touch them)?
Can it be renamed to something like forceUppercase or similar?
proposals/stdlib/hex-format.md
Outdated
| ``` | ||
|
|
||
| `BytesHexFormat` and `NumberHexFormat` classes hold format options for `ByteArray` and numeric values, correspondingly. | ||
| `uppercase` option, which is common to both `ByteArray` and numeric values, is stored in `HexFormat`. |
There was a problem hiding this comment.
We should likely discuss the name of this option once again. While it is named upperCase in code, in other places of KEEP, it is referred to as uppercase, which may indicate that it could be a more natural choice of the name, also more consistent with the name of the String/Char.uppercase() function.
Another approach could use some prefix, for example, isUpperCase or useUpperCase.
There was a problem hiding this comment.
Good point. I added a comment regarding the option name in the proposal discussion issue: #362 (comment)
Hopefully, some naming variants will be proposed by the community.
qurbonzoda
force-pushed
the
hex-format
branch
from
565881b to
359be0a
Compare
No description provided.