fix the conversion of public properties within private classes

Kotlin · Dec 18, 2023 · 7ac540a · 7ac540a
1 parent 9b853ed
commit 7ac540a
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 1 deletion.
diff --git a/...generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/toDataFrame.kt b/...generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/toDataFrame.kt
@@ -163,7 +163,7 @@ internal fun convertToDataFrame(
             }
         }
         property.javaField?.isAccessible = true
-//        property.isAccessible = true
+        property.isAccessible = true
 
         var nullable = false
         var hasExceptions = false

diff --git a/core/generated-sources/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/toDataFrame.kt b/core/generated-sources/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/toDataFrame.kt
@@ -284,4 +284,11 @@ class CreateDataFrameTests {
         // In the test above you can see decompiled code that "fixes" this strange wrapping
         result.toString() shouldBe "Speed1(kmh=null)"
     }
+
+    private class PrivateClass(val a: Int)
+
+    @Test
+    fun `convert private class with public members`() {
+        listOf(PrivateClass(1)).toDataFrame() shouldBe dataFrameOf("a")(1)
+    }
 }
diff --git a/core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/toDataFrame.kt b/core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/toDataFrame.kt
@@ -163,6 +163,7 @@ internal fun convertToDataFrame(
             }
         }
         property.javaField?.isAccessible = true
+        property.isAccessible = true
 
         var nullable = false
         var hasExceptions = false

diff --git a/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/toDataFrame.kt b/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/toDataFrame.kt
@@ -284,4 +284,11 @@ class CreateDataFrameTests {
         // In the test above you can see decompiled code that "fixes" this strange wrapping
         result.toString() shouldBe "Speed1(kmh=null)"
     }
+
+    private class PrivateClass(val a: Int)
+
+    @Test
+    fun `convert private class with public members`() {
+        listOf(PrivateClass(1)).toDataFrame() shouldBe dataFrameOf("a")(1)
+    }
 }