Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #501 to 0.12.1 #504

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Backport #501 to 0.12.1 #504

merged 4 commits into from
Nov 14, 2023

Conversation

ermolenkodev
Copy link
Contributor

No description provided.

ermolenkodev and others added 4 commits November 14, 2023 16:22
…column names clashes

Moved `convertToDataFrame` function KotlinNotebookPluginUtils and made it public to make it acessible in Kotlin Notebook plugin. An auxiliary method to generate unique variations of a string was added to fix issue with column names clashes when convert intermediate object to dataframe.

Fixes KTNB-424, KTNB-415
Introduced two public methods named `sortByColumns` in KotlinNotebookPluginUtils for sorting a dataframe-like object, or a specific dataframe by multiple columns. This added functionality will aid in sorting dataframes in Kotlin Notebook plugin. Implemented measures to handle null dataframes and conflicting column sizes.

Fixes KTNB-426.

Co-authored-by: Jolan Rensen <Jolan.Rensen@jetbrains.com>
Updated the 'generateRandomVariationOfString' function to 'generateRandomVariationOfColumnName' in 'KotlinNotebookPluginUtils.kt' to ensure uniqueness among used names. ColumnNameGenerator was used to create unique column names based on preferred name and used column names.
@ermolenkodev ermolenkodev merged commit a735105 into Kotlin:0.12.1 Nov 14, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant