Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static notebook fixes and examples #511

Merged
merged 7 commits into from
Nov 24, 2023
Merged

Static notebook fixes and examples #511

merged 7 commits into from
Nov 24, 2023

Conversation

Jolanrensen
Copy link
Collaborator

@Jolanrensen Jolanrensen commented Nov 21, 2023

Fixes #503 and #476.

This PR adds static HTML DataFrames to .ipynb files, both when rendering DataFrames in Swing and HTML such that they can be displayed on Github. For example: https://github.com/Kotlin/dataframe/blob/static-examples2/examples/notebooks/github/github.ipynb

At the moment, I excluded the json example because enabling static output makes the file 170MB+ and thus too large for GitHub. This probably needs #512 to be fixed beforehand.

Non-JS collapsible DataFrames also should be explored later: #513.

Copy link
Collaborator

@koperagen koperagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Jolanrensen
Copy link
Collaborator Author

Now I'll just have to redo everything when #513 is done

@koperagen koperagen merged commit 54d2c74 into master Nov 24, 2023
1 of 2 checks passed
@Jolanrensen
Copy link
Collaborator Author

And cherry picked into 0.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regenerate notebooks with static output
2 participants