Linter for all modules #521
Conversation
| ?: vector.setNull(i) | ||
| } | ||
|
|
||
| is LargeVarCharVector -> column.convertToString() |
There was a problem hiding this comment.
This is became more readable!
There was a problem hiding this comment.
yeah, someone didn't know also did exactly what they attempted to do with let. Honestly, I'd replace them with if (value == null) if I wrote it myself, for readability, but at least it's better now :)
|
|
||
| package test | ||
|
|
||
| import org.jetbrains.kotlinx.dataframe.annotations.ImportDataSchema |
There was a problem hiding this comment.
Did you do it manually or with automated refactoring? I had some troubles with automated
There was a problem hiding this comment.
manually, unfortunately. But it makes sense that it isn't done automatically. Since it's a String you could mean anything, so it's good IntelliJ doesn't change it.
| ) | ||
| """.trimIndent() | ||
| CREATE TABLE Sale ( | ||
| id INT PRIMARY KEY, |
There was a problem hiding this comment.
It looks like a have alternative tabulation for SQL queries in my IDEA((
Fixes #520.
When reviewing #516 I noticed we didn't have a linter enabled for all modules. This PR enabled kotlinter for all modules (except jdbc as @zaleslaw is actively working on it), plus it fixes any linting issues encountered along the way.