Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ! to DataColumnArithmetics #531

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Added ! to DataColumnArithmetics #531

merged 1 commit into from
Dec 7, 2023

Conversation

Jolanrensen
Copy link
Collaborator

Very small addition which adds !booleanColumn notation across the library similar to the other arithmetics we support.

As referenced by #530.

@Jolanrensen Jolanrensen added the enhancement New feature or request label Dec 6, 2023
@Jolanrensen Jolanrensen added this to the 0.13.0 milestone Dec 6, 2023
zaleslaw
zaleslaw approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@zaleslaw zaleslaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tricky pattern to handle Nullability in Generics:)

@Jolanrensen
Copy link
Collaborator Author

@zaleslaw not so new :) it was used in that file before, pretty useful to be able to do + 1 on a DataColumn<Int?> :)

@Jolanrensen Jolanrensen merged commit 21cb4ae into master Dec 7, 2023
2 checks passed
@Jolanrensen Jolanrensen deleted the datacolumn-not-arithmetics branch December 7, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaleslaw zaleslaw zaleslaw approved these changes

@koperagen koperagen Awaiting requested review from koperagen

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.13.+
Development

Successfully merging this pull request may close these issues.
2 participants
@Jolanrensen @zaleslaw