Dev version bump to 0.14.0 & updating deprecations #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaleslaw
reviewed
Mar 25, 2024
| @@ -112,6 +75,12 @@ private const val message_0_15 = "Will be removed in 0.15." | |||
|
|
|||
| // endregion | |||
|
|
|||
| // region WARNING in 0.15, ERROR in 0.16 | |||
|
|
|||
| private const val message_0_16 = "Will be removed in 0.16." | |||
There was a problem hiding this comment.
MESSAGE_0_16? for constants (no needs to fix, but for future)
There was a problem hiding this comment.
it's a private const so it doesn't really matter (the linter doesn't complain), but we could change it in the future if you want to
zaleslaw
reviewed
Mar 25, 2024
| @@ -7,43 +7,6 @@ package org.jetbrains.kotlinx.dataframe.util | |||
| * Level.ERROR -> Remove | |||
| */ | |||
|
|
|||
| // region WARNING in 0.12, ERROR in 0.13 | |||
|
|
|||
| private const val message_0_13 = "Will be removed in 0.13." | |||
There was a problem hiding this comment.
a, it's just a variable, no needs to be capitalized
zaleslaw
approved these changes
Mar 25, 2024
Jolanrensen
force-pushed
the
version-bump-to-0.14.0
branch
from
a245a51 to
25200a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as the title says