Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated split documentation #653

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Updated split documentation #653

merged 1 commit into from
Apr 9, 2024

Conversation

Jolanrensen
Copy link
Collaborator

Fixes #562

@Jolanrensen Jolanrensen added the documentation Improvements or additions to documentation (not KDocs) label Apr 6, 2024
@Jolanrensen Jolanrensen requested a review from zaleslaw April 6, 2024 14:45

<!---FUN splitRegex-->

```kotlin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's happened with this example? What's its future here and in codebase?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I described here #562, the example is not incorrect, but it show a bit too much information before getting to the point. It first merges string columns before splitting them again, while only the splitting part is relevant here. It should still exist in the code base to generate the right DFs tho.

@Jolanrensen Jolanrensen merged commit d9b90e7 into master Apr 9, 2024
3 checks passed
@Jolanrensen Jolanrensen deleted the split-docs-fixes branch April 9, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation (not KDocs)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The split operation documentation contains the example for another operations merge
2 participants