Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce OtherSamples.kt to generate tables for writerside docs outside Korro #695

Merged
merged 1 commit into from
May 15, 2024

Conversation

koperagen
Copy link
Collaborator

@koperagen koperagen commented May 14, 2024

Later, generated tables can be added anywhere. Example:

<dataFrame src="manual/extensionPropertiesApi1.html"/>

Copy link
Collaborator

@Jolanrensen Jolanrensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just what I needed for #635 :)
And indeed, for flexibility it's better to have the writerside styles separately like now, who knows what else we'll need it for.

@Jolanrensen Jolanrensen added the documentation Improvements or additions to documentation (not KDocs) label May 15, 2024
@Jolanrensen Jolanrensen merged commit c137ec5 into master May 15, 2024
4 checks passed
@Jolanrensen
Copy link
Collaborator

Jolanrensen commented May 15, 2024

I merged it to try it out with #635, and it seems to work great, aside from the scroll bars that are still visible. This might be due to resize-iframes.js, but I'll investigate it a little myself.
image

Edit: hmm, this might actually be normal behavior, since normally our tables aren't that wide.

@koperagen koperagen self-assigned this May 15, 2024
@koperagen koperagen added this to the 0.14.0 milestone May 15, 2024
@koperagen koperagen deleted the writerside-tables branch August 26, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation (not KDocs)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants