Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sitemap.xml #698

Merged
merged 3 commits into from
May 17, 2024
Merged

Enable sitemap.xml #698

merged 3 commits into from
May 17, 2024

Conversation

Jolanrensen
Copy link
Collaborator

@Jolanrensen Jolanrensen added the documentation Improvements or additions to documentation (not KDocs) label May 16, 2024
@Jolanrensen Jolanrensen added this to the 0.14.0 milestone May 16, 2024
@Jolanrensen Jolanrensen requested review from zaleslaw and koperagen May 16, 2024 13:02
@@ -17,6 +17,7 @@
<enable-browser-edits>true</enable-browser-edits>
<browser-edits-url>https://github.com/Kotlin/dataframe/edit/master/docs/StardustDocs/</browser-edits-url>
</variables>
<sitemap priority="0.35" change-frequency="monthly"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When do you define the priority number, how do you generate these numbers?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, just what the docs says https://www.jetbrains.com/help/writerside/generate-sitemap.html. To be honest, I'm not sure what it does.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could probably just leave out the priority, since it's optional

@zaleslaw
Copy link
Collaborator

@Jolanrensen thanks for carrying about this question

@Jolanrensen
Copy link
Collaborator Author

We need to check with WriterSide that our version gets updated so the sitemap generation feature works. It probably won't hurt to merge this already, waiting for the update, but we need to take into account it won't work right away.

@Jolanrensen Jolanrensen merged commit 5088ce8 into master May 17, 2024
4 checks passed
@Jolanrensen Jolanrensen deleted the sitemap branch May 17, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation (not KDocs)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate sitemap.xml automatically
2 participants