Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google analytics script #786

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

azhebel
Copy link
Contributor

@azhebel azhebel commented Jul 17, 2024

also:

  • meta name="google-site-verification"
  • iframe resize function

not sure if they are necessary though

@koperagen
Copy link
Collaborator

koperagen commented Jul 17, 2024

Hi! We're using a bit outdated custom writerside build, 2023.1.4 and can't update yet. This tag doesn't seem to work there.
image
So let's keep analytics-head-script-file. These are needed too, indeed

meta name="google-site-verification"
iframe resize function

@azhebel
Copy link
Contributor Author

azhebel commented Jul 17, 2024

@koperagen sure, you can keep the old tag <analytics-head-script-file> and even the old script file if you want, just make sure the actual analytics script is the one I added here, not the UA one you had previously

Do you want me to modify this MR or will you add the necessary changes manually?

@koperagen
Copy link
Collaborator

Modify the MR please :)

@azhebel azhebel force-pushed the azhebel/analytics-script branch from 050b12b to c72c3d0 Compare July 17, 2024 13:53
@azhebel
Copy link
Contributor Author

azhebel commented Jul 17, 2024

@koperagen I kept everything else except the actual script. Let's see if this helps.

@koperagen koperagen merged commit 4e3ba85 into Kotlin:master Jul 17, 2024
@koperagen
Copy link
Collaborator

Thank you! I'll deploy docs now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants