Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small implode fix #801

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Small implode fix #801

merged 3 commits into from
Aug 1, 2024

Conversation

Jolanrensen
Copy link
Collaborator

With the debug mode enabled, two failing tests of #713 were found in implode.

This PR makes sure the temporary column created in the function adheres to the given kType.

@Jolanrensen Jolanrensen requested a review from zaleslaw July 31, 2024 12:43
@Jolanrensen Jolanrensen marked this pull request as ready for review August 1, 2024 10:42
@Jolanrensen Jolanrensen requested review from zaleslaw and removed request for zaleslaw August 1, 2024 10:43
@Jolanrensen Jolanrensen mentioned this pull request Aug 1, 2024
Copy link
Collaborator

@zaleslaw zaleslaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool comments, with them the idea is much much clearer

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Generated sources will be updated after merging this PR.
Please inspect the changes in here.

@Jolanrensen Jolanrensen merged commit d463133 into master Aug 1, 2024
5 of 6 checks passed
@Jolanrensen Jolanrensen deleted the implodeFix branch August 1, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants