Change toHTML rendering to allow custom HTML content inside cells and not just text #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not just text fixes #319
koperagen
force-pushed
the
html-in-cell-rendering
branch
from
3ee238f to
8d59c97
Compare
Jolanrensen
approved these changes
Nov 25, 2024
| @@ -23,6 +23,6 @@ public data class IMG( | |||
| if (height != null) style.append("height:${height}px;") | |||
| if (maxWidth != null) style.append("max-width:${maxWidth}px;") | |||
| if (maxHeight != null) style.append("max-height:${maxHeight}px;") | |||
| return """<img src="$src" style="$style"}/>""" | |||
| return """<img src="$src" style="$style"/>""" | |||
| @@ -514,6 +516,8 @@ private fun AnyFrame.getColumnsHeaderGrid(): List<List<ColumnWithPathWithBorder< | |||
| internal fun DataFrameHtmlData.print() = println(this) | |||
|
|
|||
| /** | |||
| * By default, cell content is formatted as text | |||
There was a problem hiding this comment.
very helpful comment, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #319