Fix loading empty properties by CLI json parser. #2362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was when we used
DokkaSourceSetImpl
asTypeReference
for Jackson object mapper, we could end up with an error:The issue stems from the default implementation of
DokkaSourceSetImpl
, that if there is no such property in json, it was returningEmptyList
which cannot be cast to MutableList in case of mutating its state for CLI with global options purposes #2292 . The same problem applies toSets