Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configure version eagerly #2799

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

JavierSegoviaCordoba
Copy link
Contributor

A typical approach in some version plugins is using an object which uses internally a Property<String>, and the toString() method unwraps it.

With provider { … } unwrapping it too soon is avoided.

A typical approach in some version plugins is using an object which uses internally a `Property<String>`, and the `toString()` method unwraps it.

With `provider { … }` unwrapping it too soon is avoided.
@IgnatBeresnev
Copy link
Member

For some additional context: the problem was reported by another user in the Kotlin Community Slack (link to the message), whose project version was all of a sudden changed to 0.4.1-dev.57.uncommitted+c39fefc when running Dokka with GitHub Actions. However, the version was OK if run locally.

Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

I've started lengthy integration tests just in case, let's wait for them to complete and then it'll be ready to get merged.

(We should really remember to double check all of the other optoins, this isn't our first time running into this 😅)

@IgnatBeresnev
Copy link
Member

Looks good, thanks once again!

@IgnatBeresnev IgnatBeresnev merged commit 8d1536b into Kotlin:master Jan 11, 2023
@JavierSegoviaCordoba
Copy link
Contributor Author

JavierSegoviaCordoba commented Jan 11, 2023

You're welcome 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants