-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DokkaConfiguration: Use LinkedHashSet instead of Set to preserve order for includes when deserialize (#2999) #3006
Conversation
eunwoop
commented
May 22, 2023
- for markdown files for multi module description
Hi! Does it resolve #2999? It'll be surprised if it does, because I believe |
It’s because DokkaConfigurationImpl is serialized and then deserialized using JSON and the order is not preserved during that process. When I print the log before serialization, the order of elements in the The serialization and then deserialization happens here --> In AbstractDokkaTask, the
And then inside
|
Oh yeah, I completely forgot about it.. what a strange bug... Thanks for diving deep and researching it! Using Please, give me a few days to discuss this with my colleagues, maybe we can think of something. I'll try to get back to you on Friday |
@IgnatBeresnev |
* for markdown files for multi module description
@IgnatBeresnev Hello I updated the PR. Could you reveiw this? |
Hi! Yes, sorry for the delay and thank you for not giving up :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat solution, and I think it makes sense!
If you have the time, could you please add a simple test to core/src/test/kotlin/utilities/JsonKtTest.kt
for the parseJson
function? Just to make sure it doesn't break in the future
Thanks! |