Fix invisible packages for module names with space #3019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnatBeresnev
commented
May 30, 2023
Comment on lines
-985
to
-986
| private val ContentNode.sourceSetsFilters: String | ||
| get() = sourceSets.sourceSetIDs.joinToString(" ") { it.toString() } |
There was a problem hiding this comment.
Before every table-row, there's an invisible link - I think it's used by the anchor link to focus on the right row. This property was used for the filter value in it, but I couldn't understand if it was actually needed to be present - made no difference upon testing.
IgnatBeresnev
added a commit
that referenced
this pull request
Jun 1, 2023
(cherry picked from commit 63bed7c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3011
Read my comment to understand what exactly the problem was: #3011 (comment)
There are better ways to resolve this problem, but this is the only solution that I could think of that wouldn't lead to a lot of other regressions and problems (including for Gradle users), because the value of
scopeIdis used in other parts of the code as well, such as sorting and anchor links, so changing it would lead to regression in behaviour.One could argue that module names should not contain spaces - I would agree, but the
moduleNameproperty is used as the parent project name, so the desire to change it to something human-readable is quite understandable, and if we fix it know it's likely going to lead to bug reports. It really needs to be a separate property..Ideally, a better solution should be implemented as part of #2779 - the current logic is quite error-prone and difficult to navigate..