Support inner modifier for java non-static classes
#3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmishenev
approved these changes
Nov 21, 2023
IgnatBeresnev
approved these changes
Nov 22, 2023
| @Test | ||
| fun `java declarations nested inside annotation interface should not have kotlin inner modifier`() { | ||
| val testProject = javaTestProject { | ||
| javaFile(pathFromSrc = "JavaAnnotation.java") { |
There was a problem hiding this comment.
btw, for some reason I didn't expect Java to handle root packages correctly, but apparently it works :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2793
Note: almost all of combinations of parent/nested relations are
staticby default. Only nestingclassinsideclassorenumcould beinnerin Kotlin.P.S. Here is where IDEA renders redundant static modifiers: