-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JetBrains cache-redirector #3650
Conversation
Update both the Dokka project and integration test projects to use JetBrains cache-redirector.
d395938
to
44b9d30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would be nice to leave a small comment on how to update Gradle wrapper now
build.gradle.kts
Outdated
|
||
|
||
tasks.wrapper { | ||
val gradleVersion = "8.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to clarify: after PR merged to update the version of Gradle, we need:
- set
gradleVersion
to the new value - go to
https://gradle.org/release-checksums/
and copy the checksum - set
distributionSha256Sum
to the new value - run
gradle wrapper
correct?
Previously it was just gradle wrapper --gradle-version=8.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I will double check and document the steps. Normally I update gradle.properties
but yes, there are multiple ways.
Previously it was just gradle wrapper --gradle-version=8.8
And then re-run gradle wrapper
, otherwise the wrapper scripts won't be updated 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL how to update Gradle (while using distributionSha256Sum
). It is not simple :(
Hopefully the instructions are clear - WDYT?
Very good idea, I will do that. |
Use JetBrains cache-redirector in Dokka build, Gradle integration tests, and Maven integration tests.
Update the Gradle Wrapper task to use the cache-redirector too, and add an explanation.
Part of KT-64200