-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DGP plugin mode flags #3797
Merged
adam-enko
merged 4 commits into
master
from
adam/feat/KT-70336/rationalise-plugin-mode-flags
Sep 24, 2024
Merged
Update DGP plugin mode flags #3797
adam-enko
merged 4 commits into
master
from
adam/feat/KT-70336/rationalise-plugin-mode-flags
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-enko
added
the
runner: Gradle plugin
An issue/PR related to Dokka's Gradle plugin
label
Sep 11, 2024
Base automatically changed from
adam/feat/OSIP-355/fix-dokka-in-precompiled-script-plugins
to
master
September 19, 2024 15:17
Use `org.jetbrains.dokka.experimental.gradle.pluginMode=[V1Enabled|V2EnabledWithHelpers|V2Enabled]` to control the behaviour. Use `org.jetbrains.dokka.experimental.gradle.pluginMode.noWarn=[true|false]` to enable/disable the warning logs. KT-71236
adam-enko
force-pushed
the
adam/feat/KT-70336/rationalise-plugin-mode-flags
branch
from
September 23, 2024 07:57
59b1249
to
82e7ca3
Compare
whyoleg
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
just some minor comments, can be merged even without them
dokka-runners/dokka-gradle-plugin/src/main/kotlin/internal/PluginFeaturesService.kt
Outdated
Show resolved
Hide resolved
dokka-runners/dokka-gradle-plugin/src/main/kotlin/internal/PluginFeaturesService.kt
Show resolved
Hide resolved
I'm waiting to find someone from KBT to review... in the interim I'll assign @Tapchicoma. |
ALikhachev
approved these changes
Sep 24, 2024
adam-enko
deleted the
adam/feat/KT-70336/rationalise-plugin-mode-flags
branch
September 24, 2024 13:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
org.jetbrains.dokka.experimental.gradle.pluginMode=[V1Enabled|V2EnabledWithHelpers|V2Enabled]
to control the behaviour.Use
org.jetbrains.dokka.experimental.gradle.pluginMode.noWarn=[true|false]
to enable/disable the warning logs.KT-71236