Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoremove closing bracket when opening is removed #245

Closed
nikitinas opened this issue May 19, 2021 · 1 comment · Fixed by #308
Closed

Autoremove closing bracket when opening is removed #245

nikitinas opened this issue May 19, 2021 · 1 comment · Fixed by #308
Labels
feature
Milestone
0.11.0

Comments

@nikitinas
Copy link
Contributor

nikitinas commented May 19, 2021 •
edited
Loading

Type
fun a(
Closing bracket will be added. After backspace is pressed, closing bracket is not removed.
Refers to all kinds of brackets: (), <>, {}, []
@ileasile ileasile added this to the 0.11.0 milestone Jul 16, 2021
@ileasile
Copy link
Contributor

Code mirror code analysis is too primitive to distinguish "less sign" and "triangular bracket". So, for <> it is hard to achieve correct behavior. Regarding the bug itself - it's rather easy to fix it, fix will be delivered soon

ileasile added a commit that referenced this issue Jul 18, 2021
@ileasile
Fix completion starting logic, avoid preventDefault
8c0ec16 
Fixes #245
@ileasile ileasile mentioned this issue Jul 18, 2021
Merged
ileasile added a commit that referenced this issue Jul 18, 2021
@ileasile
Fix completion starting logic, avoid preventDefault
1f99e1e 
Fixes #245
ileasile added a commit that referenced this issue Jul 19, 2021
@ileasile
Fix completion starting logic, avoid preventDefault
d4f46fc 
Fixes #245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

Fix completion starting logic, avoid preventDefault Kotlin/kotlin-jupyter
2 participants
@nikitinas @ileasile