Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plotly descriptors #103

Merged
merged 4 commits into from
Sep 14, 2020
Merged

Add plotly descriptors #103

merged 4 commits into from
Sep 14, 2020

Conversation

altavir
Copy link
Contributor

@altavir altavir commented Sep 13, 2020

Plotly.kt and plotly.kt-server descriptors accompanied by warning message about glitches.

@altavir altavir mentioned this pull request Sep 13, 2020
Closed
@ileasile
Copy link
Contributor

Thank you for providing descriptors!
Please add description property to these JSONs: https://github.com/Kotlin/kotlin-jupyter#adding-new-libraries
And then regenerate README using ./gradlew generateReadme command.

ileasile
ileasile reviewed Sep 13, 2020
View reviewed changes
libraries/plotly-server.json Outdated Show resolved Hide resolved
libraries/plotly.json Outdated Show resolved Hide resolved
@altavir
Copy link
Contributor Author

altavir commented Sep 14, 2020

Applied both changes. Additionally fixe kmath descriptor.

@ileasile ileasile merged commit d578f13 into Kotlin:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ileasile ileasile ileasile left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@altavir @ileasile