Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries is intended as a fix for GhidraJupyter/ghidra-jupyter-kotlin#2
Using
exitProcess(0)
will terminate the entire process, but if the kernel is used as a library and embedded in another application, i.e. process this will be terminated too. Instead the code that handles the ShutdownRequest now has a somewhat inelegant check if the kernel is embedded and will instead just throw anInterruptedException
which is caught in the controlThread loop and leads to thecontrolThread
interrupting themainThread
so they both terminate and the entire kernel terminates.Because I don't know why
exitProcess(0)
was used in the first place this will only happen if the kernel is embedded for now, but if this also works for the regular usage this could be simplified to just always throwing anInterruptedException