Completion base support #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitinas
reviewed
Nov 18, 2019
build.gradle
Outdated
| @@ -23,6 +23,7 @@ allprojects { | |||
| jcenter() | |||
| mavenLocal() | |||
| mavenCentral() | |||
| maven { url '/home/ileasile/maven_repo/repo_1/maven' } | |||
nikitinas
suggested changes
Nov 18, 2019
| this.codeOnLoad = ArrayList() | ||
| } | ||
|
|
||
| fun receiver(receiver: KotlinReceiver): KotlinReplProperties { |
There was a problem hiding this comment.
There is no need in setter methods, all fields in Kotlin are properties and optional getters/setters can be added if needed (https://kotlinlang.org/docs/reference/properties.html)
There was a problem hiding this comment.
Sorry, I know this, but this was auto-converted from Java :)
| val receivers = listOf(kt) | ||
| implicitReceivers.invoke(receivers) | ||
|
|
||
| Unit |
There was a problem hiding this comment.
No need to return Unit here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completion works on TAB.
The following tokens are took int account: