Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with recursive structures #320

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Fix issue with recursive structures #320

merged 2 commits into from
Aug 12, 2021

Conversation

nikolay-egorov
Copy link
Contributor

No description provided.

Copy link
Contributor

@ileasile ileasile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also make the serialization switched off by default. Let's do it only if it was requested by execute request (can we make an additional optional field in it for that?) or :vars command was called

@nikolay-egorov
Copy link
Contributor Author

I guess we can leave it as it is for now and just send empty strings in meta data. Might reuse serialization flag we already have

@nikolay-egorov nikolay-egorov force-pushed the recursive-state-fix branch 6 times, most recently from a499bf6 to e885715 Compare August 12, 2021 16:11
@ileasile ileasile merged commit 12a60d8 into master Aug 12, 2021
@ileasile ileasile deleted the recursive-state-fix branch May 5, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The kernel hangs if a top-level variable is assigned a recursive data structure
2 participants