Use gradle variables in kernel source #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ileasile
commented
Dec 25, 2019
ileasile
commented
- Added possibility of using properties from Gradle in source code
- Fixed implementation version
…ed implementation version
ileasile
force-pushed
the
access_build_version_from_src
branch
from
a11b840 to
655d884
Compare
ileasile
force-pushed
the
access_build_version_from_src
branch
from
e97eb69 to
16f536f
Compare
nikitinas
reviewed
Dec 26, 2019
| @@ -38,7 +38,8 @@ class ReplCompilerException(val errorResult: ReplCompileResult.Error) : ReplExce | |||
| } | |||
|
|
|||
| class ReplForJupyter(val scriptClasspath: List<File> = emptyList(), | |||
| val config: ResolverConfig? = null) { | |||
| val config: ResolverConfig? = null, | |||
| val properties: RuntimeKernelProperties = RuntimeKernelProperties()) { | |||
There was a problem hiding this comment.
Why does ReplForJupyter need RuntimeKernelProperties? They are not used within it
nikitinas
reviewed
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.