Introduce class for setting up debug integration #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ileasile
suggested changes
Feb 6, 2024
...lin/org/jetbrains/kotlinx/jupyter/repl/creating/LazilyConstructibleReplComponentsProvider.kt
Outdated
Show resolved
Hide resolved
...compiler/src/main/kotlin/org/jetbrains/kotlinx/jupyter/debug/DebugIntegrationProviderMock.kt
Outdated
Show resolved
Hide resolved
...-lib/shared-compiler/src/main/kotlin/org/jetbrains/kotlinx/jupyter/debug/DebugIntegration.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/kotlinx/jupyter/repl/creating/creatingUtil.kt
Outdated
Show resolved
Hide resolved
...-lib/shared-compiler/src/main/kotlin/org/jetbrains/kotlinx/jupyter/debug/DebugIntegration.kt
Outdated
Show resolved
Hide resolved
...-lib/shared-compiler/src/main/kotlin/org/jetbrains/kotlinx/jupyter/debug/DebugIntegration.kt
Outdated
Show resolved
Hide resolved
|
I'll think about it one more time. Now it indeed seems like we don't need abstraction for debug just yet |
nikolay-egorov
force-pushed
the
debug-integration-provider
branch
from
ded9168 to
42bd6c9
Compare
ileasile
suggested changes
Feb 9, 2024
...ib/shared-compiler/src/main/kotlin/org/jetbrains/kotlinx/jupyter/messaging/MessageHandler.kt
Outdated
Show resolved
Hide resolved
...ared-compiler/src/main/kotlin/org/jetbrains/kotlinx/jupyter/repl/notebook/MutableNotebook.kt
Outdated
Show resolved
Hide resolved
...ed-compiler/src/main/kotlin/org/jetbrains/kotlinx/jupyter/repl/notebook/impl/NotebookImpl.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/kotlinx/jupyter/messaging/MessageHandlerImpl.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/kotlinx/jupyter/repl/impl/ReplForJupyterImpl.kt
Outdated
Show resolved
Hide resolved
nikolay-egorov
force-pushed
the
debug-integration-provider
branch
from
42bd6c9 to
1dae851
Compare
nikolay-egorov
force-pushed
the
debug-integration-provider
branch
from
1dae851 to
b1b7a3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, newer version of kernel will keep thread for creating breakpoints