-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model name to the summary method #120
Comments
I could do this one :) |
@zaleslaw to what extend do both summary methods have to be refactored? E.g. does the method signature have to change at all? |
I've changed the ticket description regarding refactoring: the refactoring will be optional, the API is not under stability guarantees and could be changed. The refactoring is just an idea, looks like it could be refactoring, but it's your choice as a contributor: propose the refactoring (with minor changes in the signature that doesn't affect all examples and tests) because there is some copy-paste there and common logic, but PR could be merged and without refactoring |
@zaleslaw do the above commits cover the first 3 points in this issue sufficiently? Or is this not what you meant. And I can look into the refactoring yes. |
I've added the Contributing Guidelines. Please check this. |
You solution is simple and solves the problem |
I suggest do things step by step, the final form of model summary is unclear and there are a few moments related to logging, jupyter integration and so on. I suggest to finish this ticket and if the form of summary will be changed, we will not ignore the modelname |
- based of toyresnet - also offers base for other Functional model tests
* Added missing saving functions for ReLU and ELU activation layers (JetBrains#78) * Reverted changes to the imports * Added "Model name: $name" line (if `name` is not null) to summary method #120 * Added model name validation in SequentialCompilationTest.summary #120 * Added "type" part to summary line for Sequential model #120 * Wrote simple test for Functional model summary (#120) - based of toyresnet - also offers base for other Functional model tests
Our models could have names, but the current version of summary method (for both, Sequential and Functional models) doesn't support model name displaying.
The PR should include:
The text was updated successfully, but these errors were encountered: