-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Soft shrink activation function #170
Comments
Hello @zaleslaw, I would like to implement this one. |
Great @michalharakal will wait a PR! |
Hi, @michalharakal Do you have any updates on this issue? Do you need some help from my side? |
@zaleslaw, sorry for delay, I was just busy with other stuff, by accident I could gave a talk on a Kotlin related conference as backup. I plan to have a look on issue this weekend. |
I'm absolutely ok with that. I just ping you to help if something is unclear. It's not a critical issue, I moved it to the 0.4 release |
…xes failing tests. Related-To: Kotlin#170
…xes failing tests. Related-To: Kotlin#170
…xes failing tests. Related-To: Kotlin#170
* Add initial implementation of Softshrink activation function. Test are still missing. * Add test based on python code. https://github.com/tensorflow/addons/blob/master/tensorflow_addons/activations/tests/softshrink_test.py Related-To: #170 * Reimplement SoftShrinkActivation using tf.where operand. This also fixes failing tests. Related-To: #170
The Soft shrink activation function is missed in KotlinDL.
The desired PR addressing this issue should include:
SoftShrinkActivation
(you can take inspiration from the implementation ofHardSigmoid
as reference) added to theActivations.kt
fileapi
moduleP.S. If you want to take this ticket, please leave the comment below
P.P.S Read the Contributing Guidelines.
The reference implementation could be taken from tensorflow-addons
The text was updated successfully, but these errors were encountered: