Fix initializers import and export #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliabeliaeva
force-pushed
the
initializer-fixes
branch
from
008d7dd to
faf79cb
Compare
juliabeliaeva
force-pushed
the
initializer-fixes
branch
2 times, most recently
from
4149c70 to
5116e4c
Compare
… the compatibility mode
…ompatibility is not required
juliabeliaeva
force-pushed
the
initializer-fixes
branch
from
5116e4c to
8733aad
Compare
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/initializer/Constant.kt
Show resolved
Hide resolved
api/src/test/kotlin/org/jetbrains/kotlinx/dl/api/inference/keras/ModelLoaderTest.kt
Show resolved
Hide resolved
| import org.jetbrains.kotlinx.dl.api.core.layer.core.Input | ||
| import org.junit.jupiter.api.Test | ||
|
|
||
| class InitializerImportExportTest { |
There was a problem hiding this comment.
One optional enhancement that comes to mind is to add tests comparing outputs of original models and deserialized ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes intializers import and export, plus adds some of the missing initializers:
Constant,Ones,Zeros,OrthogonalandTruncatedNormal. This will fix #331.