Fix variables initialization #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliabeliaeva
force-pushed
the
fix-variables-initialization
branch
2 times, most recently
from
1cb1b00 to
b73970f
Compare
…tion For some initializers, like Zeros, initializer operations are named differently from what is expected. Because of this, such operations could not be found by name. Keeping initializer in the KVariable allows to access it directly.
…sorFlowInferenceModel It won't work as the model does not have any layers.
…phTrainableModel For some initializers, like Zeros, initializer operations are named differently from what is expected. Because of this, such operations could not be found by name. Getting a corresponding KVariable allows to access the initializer directly.
juliabeliaeva
force-pushed
the
fix-variables-initialization
branch
from
5e0e24a to
d06f428
Compare
|
I'll take it for review |
zaleslaw
reviewed
May 5, 2022
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/inference/keras/WeightLoader.kt
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/KVariable.kt
Outdated
Show resolved
Hide resolved
|
I suppose it could be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially (only for
GraphTrainableModel) addresses #4 by storing the initializerOperandinKVariableand accessing it directly instead of trying to find it by name. It also refactors loading variable values when reading model from txt files or copying.