Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to simplify Layer building api by doing the following:
ZeroPadding1D
andConcatenate
layers).Layer#build
andLayer#forward
functions.GraphTrainableModel#build
andGraphTrainableModel#forward
functions.This change was proposed as a part of Layer api simplification. Apart from the benefits described in linked proposal, having a single
build
method will make it easier to splitLayer
into an immutableLayer
containing variables and layer output and a reusableLayerBuilder
for building theLayer
.Possible downsides so far consists of one thing: the api no longer will mimic Keras api and it would be more difficult for contributors to borrow its code to implement new layers.