Extract tensorflow-dependent classes into a separate module #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliabeliaeva
force-pushed
the
extract-tf
branch
from
39dcfaa to
24f9462
Compare
ermolenkodev
approved these changes
Aug 2, 2022
juliabeliaeva
added a commit
that referenced
this pull request
Aug 2, 2022
* Remove unnecessary usages or TensorFlowInferenceModel type * Extract ModelType interface to a separate file * Move Metric implementations and conversion functions to the Metric.kt source file * Remove unnecessary conversions from Shape to TensorShape * Cleanup ShapeFunctions * Remove dependency from TensorShape on Shape * Allow to get array shape as a TensorShape * Move flattenFloats function to a separate file * Use model storage url from the ModelHub property
juliabeliaeva
added a commit
that referenced
this pull request
Aug 2, 2022
|
Pushed manually as 2 commits: one with the preliminary work, one with the move (to better preserve file history). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will split "api" module into two:
InferenceModel,ModelHuband supporting classes, plus some dataset code.TensorflowInferenceModeland its implementation.First commits prepare the split, moving classes between files and separating functionality, last commit adds gradle scripts and actually makes the move.