Swing visualization refactoring #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always convert raw output to the high-level objects. This allows to reuse the same visualization methods and to get rid of the extra code.
This allows to get rid of the unnecessary conversion of the image to FloatArray and back, and use the input image as is (applying preprocessing only to resize it when needed).
* Use antialiasing * Use float coordinates instead of integers * Draw pose edges under vertices * Use default font face and size for labels * Adjust labels location * Specify precision for outputting probability * Cleanup code
This allows to show detection results for several images in one frame.
ermolenkodev
approved these changes
Sep 19, 2022
juliabeliaeva
added a commit
that referenced
this pull request
Sep 19, 2022
* Remove unused code * Move detected result visualization to a separate file * Remove visualization methods for the raw output Always convert raw output to the high-level objects. This allows to reuse the same visualization methods and to get rid of the extra code. * Extract method to show a frame with content * Move ImagePanel to the visualization package * Use BufferedImage to visualize detection results This allows to get rid of the unnecessary conversion of the image to FloatArray and back, and use the input image as is (applying preprocessing only to resize it when needed). * Extract functions to draw detection results on a graphics and remove duplication * Enhance detection results visualization * Use antialiasing * Use float coordinates instead of integers * Draw pose edges under vertices * Use default font face and size for labels * Adjust labels location * Specify precision for outputting probability * Cleanup code * Replace functions showing frames with functions returning panels This allows to show detection results for several images in one frame. * Skip low-confidence pose detection results * Add documentation
This was referenced Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites swing-based visualisation, cleaning-up code and removing duplications. Major changes are:
BufferedImagetoFloatArrayand back, and unnecessary preprocessing before visualisation.Example.
Before:
After: