Introduce new general-purpose prediction methods for InferenceModel #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes classification methods from the
InferenceModel
interface in favor of the more general api. It introduces two prediction methods: for single input and for multiple inputs and adds api to extract prediction results from the model. Instance methods are replaced with the following options for classification:PredictionKt#predictLabel
/PredictionKt#predictProbabilities
extensions or the model could be wrapped intoImageRecognitionModelBase
.InferenceModel#predict(kotlin.Pair<float[], TensorShape>, Function1<? super R,? extends T>)
could be used combined with theInferenceResultConverter
for result extraction.Additional comments:
TensorResult
right now only has a list of tensors, but ideally it could also contain a map "output name" -> "tensor" and allow access byString
.InferenceResultConverter
only has 2 methods returningLongArray
andFloatArray
, this list should be expanded for other data types.InferenceModel
does not provide enough input-output information. Currently it only hasinputDimensions
property, instead we should replace it with something similar toOnnxInferenceModel#inputInfo
/outputInfo
to get access to all inputs and outputs.