Fix dimension order in the image shape #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliabeliaeva
force-pushed
the
image_shape
branch
from
4d43480 to
1548e0e
Compare
juliabeliaeva
force-pushed
the
image_shape
branch
2 times, most recently
from
e32925b to
56fc54f
Compare
…rations The order should be HWC, not WHC.
juliabeliaeva
force-pushed
the
image_shape
branch
from
56fc54f to
024ab59
Compare
zaleslaw
requested changes
May 3, 2023
...rc/jvmTest/kotlin/org/jetbrains/kotlinx/dl/impl/preprocessing/PreprocessingFinalShapeTest.kt
Show resolved
Hide resolved
...rc/jvmTest/kotlin/org/jetbrains/kotlinx/dl/impl/preprocessing/PreprocessingFinalShapeTest.kt
Show resolved
Hide resolved
...rc/jvmTest/kotlin/org/jetbrains/kotlinx/dl/impl/preprocessing/PreprocessingFinalShapeTest.kt
Show resolved
Hide resolved
|
I checked once again, everything seems correct to me. |
zaleslaw
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of the dimensions did not matter that much in the 0.5.* version, since it's rarely used. But in 0.6 we use the output shape to create tensors passed to the models, so it's important to have this correct. In quite a few models input width is equal to the input height, but for the Ultraface models these dimensions are different, so the
FaceDetectionWithVisualization.ktexample will fail in master branch without the fix.