-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebAssembly target #334
Conversation
Could you please also elaborate on the publication process of For now, Deploy build has always been red, as wasm target was published from the separate branch. Is the configuration going to be fixed? |
Can we also set up a test build of coroutines with the enabled wasm target and atomicfu dependency before merging this, so that we are sure that no transformations are applied, all dependencies are present and all the necessary artefacts are published? |
This tests already runs perfectly with your main teamcity configuration. We are going remove that red wasm configuration as soon as this MR will be merged. |
I do not know how to do that. I have already made MR for coroutines and this coroutines branch works perfectly with this Wasm AtomicFU on local machine (using train build). But I dont know how to use this train mode on CI. |
d9e4fd9
to
8508b5f
Compare
atomicfu/src/commonMain/kotlin/kotlinx/atomicfu/OptionalJsName.kt
Outdated
Show resolved
Hide resolved
f9804ed
to
96568e3
Compare
Could you please add a test project for
In overall all the changes look good to me 🙏🏻 |
1c55c5a
to
f37bd1d
Compare
f37bd1d
to
4479347
Compare
Do you also have plans to add wasmWasi? |
BTW, should we also update the README to mention the new target there? |
Same implementation as in K/JS but without @JsName annotations
4479347
to
b58cc61
Compare
Rebased the branch on the latest develop branch with Integration tests |
@hfhbd yes, I've added support of |
I've introduced For wasm targets |
Mentioned in README that the library provides support of all platforms including Wasm (since Kotlin 1.9.20) |
atomicfu-gradle-plugin/src/main/kotlin/kotlinx/atomicfu/plugin/gradle/AtomicFUGradlePlugin.kt
Outdated
Show resolved
Hide resolved
atomicfu-gradle-plugin/src/main/kotlin/kotlinx/atomicfu/plugin/gradle/AtomicFUGradlePlugin.kt
Show resolved
Hide resolved
atomicfu-gradle-plugin/src/main/kotlin/kotlinx/atomicfu/plugin/gradle/AtomicFUGradlePlugin.kt
Show resolved
Hide resolved
Co-authored-by: Filipp Zhinkin <filipp.zhinkin@gmail.com>
Co-authored-by: Filipp Zhinkin <filipp.zhinkin@gmail.com>
atomicfu/src/commonMain/kotlin/kotlinx/atomicfu/OptionalJsName.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Filipp Zhinkin <filipp.zhinkin@gmail.com>
atomicfu/src/jsAndWasmSharedMain/kotlin/kotlinx/atomicfu/locks/Synchronized.kt
Outdated
Show resolved
Hide resolved
...esting/src/functionalTest/kotlin/kotlinx.atomicfu.gradle.plugin.test/cases/MppProjectTest.kt
Outdated
Show resolved
Hide resolved
…N_FINAL_EXPECT_CLASSIFIER")
…_SAME_MEMBERS_AS_NON_FINAL_EXPECT_CLASSIFIER_WARNING")
Same implementation as in K/JS but without @JsName annotations