SafeCollector rework #1196
Merged
SafeCollector rework #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
qwwdfsad
commented
May 16, 2019
•
qwwdfsad
commented
- Strengthen flow context preservation invariant
- Cache result of the context check thus speeding up safe collector on happy path by a factor of three
- Separate fast and slow paths in JobSupport to drastically change inlining decisions of the JVM that are crucial for leaf coroutines with flows
qwwdfsad
changed the title
* Cache result of the context check thus speeding up safe collector on happy path by a factor of three * Separate fast and slow paths in JobSupport to drastically change inlining decisions of the JVM that are crucial for leaf coroutines with flows
* Add additional check in SafeCollector with an error message pointing to channelFlow
* Improve performance of the CoroutineId check in SafeCollector
Fixes #1210
qwwdfsad
changed the title
elizarov
suggested changes
May 23, 2019
kotlinx-coroutines-core/common/src/flow/internal/SafeCollector.kt
Outdated
Show resolved
Hide resolved
kotlinx-coroutines-core/common/src/flow/internal/SafeCollector.kt
Outdated
Show resolved
Hide resolved
elizarov
suggested changes
May 27, 2019
elizarov
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.