Adjust behavior of conflated channel to deliver last value #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
requested changes
Jun 2, 2019
kotlinx-coroutines-core/common/src/channels/ConflatedChannel.kt
Outdated
Show resolved
Hide resolved
kotlinx-coroutines-core/common/src/channels/ConflatedChannel.kt
Outdated
Show resolved
Hide resolved
|
I think we should document this behaviour somewhere, e.g. around |
|
I've fixed the linearizability & moved the code. As for docs, it seems to be already documented this way right here: https://kotlin.github.io/kotlinx.coroutines/kotlinx-coroutines-core/kotlinx.coroutines.channels/-channel/index.html |
qwwdfsad
approved these changes
Jun 4, 2019
zach-klippenstein
added a commit
to square/workflow
that referenced
this pull request
Jun 13, 2019
- Breakage in `CoroutineWorkflow` was caused by Kotlin/kotlinx.coroutines#1158. - Breakage in `ReactorAsWorkflowIntegrationTest` was probably caused by Kotlin/kotlinx.coroutines#1239.
zach-klippenstein
added a commit
to square/workflow
that referenced
this pull request
Jun 13, 2019
- Some things that were `@FlowPreview` have been graduated to `@ExperimentalCoroutinesApi`. - Breakage in `CoroutineWorkflow` was caused by Kotlin/kotlinx.coroutines#1158. - Breakage in `ReactorAsWorkflowIntegrationTest` was probably caused by Kotlin/kotlinx.coroutines#1239.
zach-klippenstein
added a commit
to square/workflow
that referenced
this pull request
Jun 26, 2019
- Some things that were `@FlowPreview` have been graduated to `@ExperimentalCoroutinesApi`. - Breakage in `CoroutineWorkflow` was caused by Kotlin/kotlinx.coroutines#1158. - Breakage in `ReactorAsWorkflowIntegrationTest` was probably caused by Kotlin/kotlinx.coroutines#1239.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1235
Fixes #332