-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop building and publishing compatibility MPP metadata variant #3809
Conversation
Also remove flag `kotlin.mpp.enableGranularSourceSetsMetadata` that has no effect anymore
@@ -278,7 +274,7 @@ configure(subprojects.findAll { !unpublished.contains(it.name) }) { | |||
|
|||
List<String> jarTasks | |||
if (isMultiplatform(it)) { | |||
jarTasks = ["jvmJar", "metadataJar"] | |||
jarTasks = ["jvmJar"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether we need this version info in allMetadataJar instead or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I've checked the contents locally, will publish dev version to space and poke it a bit, will merge shortly after
I will need this commit also in |
You can ask @mshishkina to rebase |
What is |
@LouisCAD it's a branch used to test kotlinx.coroutines build with the latest dev Kotlin compiler version |
Also, remove flag `kotlin.mpp.enableGranularSourceSetsMetadata` that has no effect anymore (cherry picked from commit 5c4a252)
Please review the changes in the published artifacts in kotlinx-coroutines-core and kotlinx-coroutines-test:
-all
classifier, which was previously a common klib.