Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix binary incompatibility introduced in #4261 #4310

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix binary incompatibility introduced in #4261 #4310

merged 1 commit into from
Dec 20, 2024
+23 −0

Conversation

dkhalanskyjb
Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb commented Dec 20, 2024 •
edited
Loading

Fixes #4309

@dkhalanskyjb dkhalanskyjb marked this pull request as ready for review December 20, 2024 09:55
@dkhalanskyjb
Copy link
Collaborator Author

dkhalanskyjb commented Dec 20, 2024 •
edited
Loading

I couldn't reproduce the crash yet, but I do get a warning when I link some Wizard-produced iOS code against 1.10.0 (see #4309), but I don't get that warning when I compile the code against a locally published version with this fix. Crash successfully reproduced. EDIT: the crash gets fixed by the proposed change!

@qwwdfsad
Copy link
Member

It is targeting master branch. Is it on purpose?

@dkhalanskyjb dkhalanskyjb changed the base branch from master to develop December 20, 2024 10:50
@dkhalanskyjb dkhalanskyjb merged commit 2a9b88c into develop Dec 20, 2024
1 check failed
@dkhalanskyjb
Copy link
Collaborator Author

Not really important, as we are publishing a release immediately in any case, but sure, no reason not to follow the rule.

@dkhalanskyjb dkhalanskyjb deleted the dk-fix-runnable-compatibility branch December 20, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.10.0 iOS target crash
2 participants
@dkhalanskyjb @qwwdfsad