Do not remove type discriminator in unsafe manner during polymorphic … #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JSON deserializer, properly filter out it in unknown keys check instead Fixes #807
|
The commit fails because of problems in K/N. PTAL |
sandwwraith
reviewed
Apr 22, 2020
runtime/commonMain/src/kotlinx/serialization/json/internal/TreeJsonInput.kt
Outdated
Show resolved
Hide resolved
runtime/commonTest/src/kotlinx/serialization/features/PolymorphismTest.kt
Outdated
Show resolved
Hide resolved
sandwwraith
reviewed
Apr 22, 2020
...commonTest/src/kotlinx/serialization/json/polymorphic/JsonDeserializePolymorphicTwiceTest.kt
Outdated
Show resolved
Hide resolved
sandwwraith
reviewed
Apr 24, 2020
runtime/commonTest/src/kotlinx/serialization/features/PolymorphismTest.kt
Outdated
Show resolved
Hide resolved
...commonTest/src/kotlinx/serialization/json/polymorphic/JsonDeserializePolymorphicTwiceTest.kt
Outdated
Show resolved
Hide resolved
qwwdfsad
force-pushed
the
polymorphic-fix
branch
from
067efc0
to
5f3d67a
Compare
sandwwraith
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…JSON deserializer, properly filter out it in unknown keys check instead
Fixes #807