Modify Digest.compress API to add an offset
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
This PR modifies the
Digest.compressfunction such that it now includes an offset.THIS IS AN API BREAKING CHANGE, but only for implementors of
Digest(i.e.KotlinCrypto/hash).By including an
offset: Int, this drastically increases performance asDigestno longer needs to array copyinputinto the buffer.Will require a
0.2.0release, as well as a version bump ofhashandMACsrepository.A
0.2.0-SNAPSHOTis available from MavenCentral. The snapshot was also tested in theKotlinCrypto/hashrepository with the API modification. Everything worked as expected.