Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Fix for PDF texts not being selectable' #240

Open
wants to merge 2 commits into
base: 1.0.x
Choose a base branch
from

Conversation

malthe
Copy link
Contributor

@malthe malthe commented May 14, 2019

Co-authored-by: aziesemer aziesemer@users.noreply.github.com

Co-authored-by: aziesemer <aziesemer@users.noreply.github.com>
@aziesemer
Copy link
Contributor

There was a bug in this version because I was not copying save_cursor by value.
Use in cairosvg/surface.py:
import copy
...
save_cursor = copy.deepcopy((self.cursor_position, self.cursor_d_position, self.text_path_width))

See:
58ac97c

@liZe
Copy link
Member

liZe commented May 14, 2019

Hello!

I can merge this pull request when tests are fixed, but I'd like to avoid a new 1.x version: Python 2 will be dead at the end of the year, it's probably time to port old code to Python 3 instead of backporting new code to Python 2 😇.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants