Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow build on system with LANG="C" by defaut #21

Merged
merged 1 commit into from
Oct 31, 2013
Merged

allow build on system with LANG="C" by defaut #21

merged 1 commit into from
Oct 31, 2013

Conversation

pmakowski
Copy link
Contributor

Please made the change to allow the build on distributions build systems like Mageia or Fedora without patches or hack

Please made the change to allow the build on distributions build systems like Mageia or Fedora without patches or hack
@SimonSapin
Copy link
Member

Is this a problem on Python 2, 3, or both?

@pmakowski
Copy link
Contributor Author

on Python 3, but the patch is ok for both

it is a common issue

without the patch :

+ /usr/bin/python3 setup.py build
Traceback (most recent call last):
  File "setup.py", line 7, in <module>
    path.join(path.dirname(__file__), 'cairocffi', '__init__.py')
  File "/usr/lib/python3.3/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 2453: ordinal not in range(128)

@SimonSapin
Copy link
Member

Merged, thanks.

SimonSapin added a commit that referenced this pull request Oct 31, 2013
allow build on system with LANG="C" by defaut
@SimonSapin SimonSapin merged commit ba0269a into Kozea:master Oct 31, 2013
@pmakowski pmakowski deleted the patch-1 branch October 31, 2013 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants