-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ffi import when package pip installed #61
Conversation
Import the built ffi modules from `cairocffi._ffi` rather that `._ffi`, so that if the package has been installed, this will pick up the compiled modules that are installed rather than insisting they be re-built in the source directory. This has the unfortunate side-effect of possibly hiding any problems if the cdefs are changed but the package is not re-built in the source tree.
But let xfail for Travis' cairo version from Ubuntu 12.04
This doesn’t fix the issue described at #60 (comment) . The output is the same. You can try it with |
Hmm, if I do that then
to explicitly run from the site-packages installation rather than the source, I get tox to pass. |
That was it, good catch. I cherry-picked one of your commits but did the rest different: e374c44 The XCB test have been unreliable for me, though. Sometimes the python process gets killed with SIGABRT. |
That looks good, thanks for cleaning that up. Were you getting errors with any version in particular? I was having some problems with 2.7 while I was trying to get tox running, but it may have been how I was getting it to run. I can try to look into it. If there's nothing else, is there any chance of getting a point release soon? We need to do the same cffi 1.0 changeover in Qtile, and since we use cairocffi for some drawing, we need to depend on a version that also uses out-of-line cffi. Thanks. |
No, pretty much all Python versions tested were affected by this SIGABRT… sometimes. I was kinda lazy to write the changelog, but I just uploaded 0.7 to PyPI without it. |
Hmm, alright, I can play around with it and come back if I can find On Fri, Jun 5, 2015 at 11:20 AM, Simon Sapin notifications@github.com
|
Import the built ffi modules from
cairocffi._ffi
rather that._ffi
, so that if the package has been installed, this will pick up the compiled modules that are installed rather than insisting they be re-built in the source directory. This has the unfortunate side-effect of possibly hiding any problems if the cdefs are changed but the package is not re-built in the source tree.Also, get the XCB tests running on Travis, though they will be xfailed until Travis bumps to Ubuntu 14.04.